fix(cli): accept /s/ share URLs in import#36396
Open
AayushMainali-Github wants to merge 1 commit into
Open
Conversation
GitHub PR session links still use /s/<id>, but parseShareUrl only accepted /share/<id>, so opencode pr import failed on those URLs.
CreatorGhost
added a commit
to CreatorGhost/TheCode
that referenced
this pull request
Jul 12, 2026
Ported from upstream anomalyco#36396.
CreatorGhost
added a commit
to CreatorGhost/TheCode
that referenced
this pull request
Jul 12, 2026
Ported from upstream anomalyco#36396.
CreatorGhost
added a commit
to CreatorGhost/TheCode
that referenced
this pull request
Jul 12, 2026
Ported from upstream anomalyco#36396.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #36395
Type of change
What does this PR do?
opencode importonly accepted/share/<id>URLs. Share links in GitHub PR bodies still use/s/<id>, andopencode prtries to import those, so import failed.parseShareUrlnow accepts both/share/and/s/. Updated the unit tests and the invalid-URL hint.How did you verify your code works?
Ran
bun test test/cli/import.test.tsinpackages/opencode.Screenshots / recordings
N/A
Checklist